search

bioelectric-interfaces / nfb_studio

NFB experiment designer.
https://bioelectric-interfaces.github.io/nfb_studio/
1 stars 0 forks source link

Expansion of features #4

Closed aksiotis closed 3 years ago

aksiotis commented 3 years ago

Below are the sections from the nfb lab xml file that are not supported by Studio. Mostly, these are the properties of the derived signal

 'bDisableSpectrumEvaluation',
 'sROILabel',
 'sTemporalType',
 'fTemporalFilterButterOrder',
 'sTemporalSmootherType',
 'sStatisticsType',
 'fRandomOverTime'
bindreams commented 3 years ago

I've created a table to make sure that I've got everything right.

Property Location Range of Values Default Extra Information
bDisableSpectrumEvaluation ? Yes/No No Obsolete
sROILabel ? ? ? Skip for now
sTemporalType Signal envdetector/filter/identity ? Envelope - envdetector If bandpass filter is the last node - filter if not identity only
fTemporalFilterButterOrder Bandpass Filter 1-4 2 Only if butterwort, Name: Filter order
sTemporalSmootherType Envelope Detector exp/savgol exp Smoother type: Exponential, Sov... In the future, new node?
sStatisticsType Block max/meanstd meanstd Statistics type: min-max/Standardize
fRandomOverTime Block 0+ 0 [fDuration, fDuration + this value] is range of block time durations

There is quite a bit of blank spots, because we have not discussed some of these properties. As far as I understand, not all of these need to be added, because pynfb exports some unused information. Could you correct any mistakes and fill in the blanks for me? I will then proceed with adding the properties to NFB Studio.

bindreams commented 3 years ago

Implemented sTemporalType and fTemporalFilterButterOrder in master. Please take a look. I will hopefully finish the rest today/tomorrow.

bindreams commented 3 years ago

Implemented in master. Please verify if everything is working as intended, then you can close the issue.

aksiotis commented 3 years ago

Implemented in master. Please verify if everything is working as intended, then you can close the issue.

Ok, I am working on it right now

aksiotis commented 3 years ago

Every required feature works inside Studio (I can edit it and save into xml), but there is a problem with the default values during the importing an xml created by nfb lab and studio as well (there is an issue about it in the nfb repository, but I think it is the problem of studio). Should I close this issue and address the problem in another one?

bindreams commented 3 years ago

Yes, thank you