bioforensics / MicroHapulator

Tools for empirical microhaplotype calling, forensic interpretation, and simulation.
https://microhapulator.readthedocs.io/
Other
6 stars 1 forks source link

Fix mhpl8r diff command #75

Closed standage closed 4 years ago

standage commented 4 years ago

The profile.alleles() function returns None when a profile has no alleles for a marker. The diff module applies set operations on the output of this function without any error checking, which is problematic when a None is returned. This update modifies the function to return an empty set instead of None, so that set operations will work as expected.

The mhpl8r diff command was also updated so that each allele is printed on a dedicated line, rather than joined on the same line.

This update incidentally includes a few small changes to the location of certain package files.


codecov-io commented 4 years ago

Codecov Report

Merging #75 into master will increase coverage by 1.81%. The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #75      +/-   ##
==========================================
+ Coverage   95.76%   97.57%   +1.81%     
==========================================
  Files          25       25              
  Lines         803      743      -60     
  Branches      158      141      -17     
==========================================
- Hits          769      725      -44     
+ Misses         21        8      -13     
+ Partials       13       10       -3
Impacted Files Coverage Δ
microhapulator/panel.py 91.66% <ø> (+9.46%) :arrow_up:
microhapulator/sim.py 100% <100%> (ø) :arrow_up:
microhapulator/__init__.py 93.02% <100%> (-0.32%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 64691fc...b8f2847. Read the comment docs.