search

bioforensics / pytaxonkit

Python bindings for the TaxonKit library
Other
31 stars 2 forks source link

Fix bug with pytaxonkit.name #26

Closed standage closed 2 years ago

standage commented 2 years ago

Small bug fix for pytaxonkit.name. Also, looks like some Symplocos-ologist has been busy at work since pytaxonkit was last updated, so made some minor changes to the expected output of the test suite.

Closes #25.

standage commented 2 years ago

Hi @philippbayer, can you confirm this fix works for you?

philippbayer commented 2 years ago

I can confirm it now works on my system!! Thanks so much

standage commented 2 years ago

Investigated the Popen bufsize parameter as a potential alternative solution, but wasn't able to get it to work. I'm happy with this fix in any case.

I'm pretty sure the changes in this PR already address the cause of the monthly cron CI failure.

Ready for review and merge!

RyanBerger98 commented 2 years ago

LGTM! Thank you!