search

bioforensics / yeat

YEAT: Your Everyday Assembly Tool
Other
1 stars 0 forks source link

Adding Hifiasm and Hifiasm-meta for Pacbio Hifi-reads #49

Closed danejo3 closed 10 months ago

danejo3 commented 11 months ago

The purpose of this PR is to add two new assemblers: hifiasm and hifiasm-meta for Pacbio Hifi-Reads.

In order to run the tests for hifiasm and hifiasm-meta, run the make command make metadata to download the test Metagenomics data.

agshumate commented 11 months ago

@danejo3 it looks like in commit 7137b3ee982d592321ce12a4a6b4d680fc7f3857 on the main branch you reverted commit 96da565310d73826fec99d065d2aa80e3ea64426 which was the changes in #47 . To keep those changes in there it looks like you'd want to revert commit 502a6abbf16b45c8a982492ae7b2b762bf60e741 correct? If this is not the case and you can't recover the changes in #47 , I'd recommend creating two separate pull requests. One to replace the changes in #47 and another for Hifiasm and Hifiasm-meta as they are different functionalities. It will also making it easier to compare and verify that you have successfully reintroduced the correct changes from #47.

standage commented 10 months ago

Tests completed successfully for me. Let me know if you want to talk awk.