search

biogo / graphics

biogo genomic graphics repository
9 stars 3 forks source link

update to match new api for FillText #5

Closed brentp closed 8 years ago

brentp commented 8 years ago

required to run human.go

brentp commented 8 years ago

guess I'd better run the tests. :(

brentp commented 8 years ago

not clear how best to update the tests. How were those generated? Or is gonum/plot in enough flux that it's best to wait on this?

kortschak commented 8 years ago

Test cases are created through a relatively painfull process. I can do that.

kortschak commented 8 years ago

It looks one is failing on visual inspection though. The axis label on axis-0 is incorrect (it should be oriented parallel with the scale labels on that axis - it is rotated 90°CW from what it should be). I'll generate test cases when you have fixed that (use -allpic when you run the rings test). If you checkout gonum/plot at 986a404 you can get the previous behaviour for a known good state.

brentp commented 8 years ago

OK. Latest push makes sensible change that seems fix that issue.

kortschak commented 8 years ago

Updated tests are here https://gist.github.com/kortschak/2ba3e457b134fe8a9ce45f67221fd5fe

brentp commented 8 years ago

those tests pass.

kortschak commented 8 years ago

Please add them to this PR.

brentp commented 8 years ago

is this good-to-merge now?

kortschak commented 8 years ago

Thank you for doing this.