search

bioimage-io / JDLL

The Java library to run Deep Learning models
https://github.com/bioimage-io/JDLL/wiki
Apache License 2.0
27 stars 6 forks source link

Add dependencies jackson-databind and jackson-dataformat-msgpack to pom.xml #30

Closed stefanhahmann closed 11 months ago

stefanhahmann commented 1 year ago

This PR adds the dependencies com.fasterxml.jackson.core.jackson-databind and org.msgpack.jackson-dataformat-msgpack version 0.9.5 to the pom.xml

Without these dependencies, it seems not to be possible to build this project. I observed two missing imports in https://github.com/bioimage-io/JDLL/blob/main/src/main/java/io/bioimage/modelrunner/bioimageio/bioengine/BioengineInterface.java, import org.msgpack.jackson.dataformat.MessagePackFactory; and import com.fasterxml.jackson.databind.ObjectMapper;

These 2 imports are not missing anymore, after the 2 new dependencies have been added to the pom.xml

carlosuc3m commented 11 months ago

Thanks for the pr, forgot to add that dep from my local changes!