search

bioimage-io / JDLL

The Java library to run Deep Learning models
https://github.com/bioimage-io/JDLL/wiki
Apache License 2.0
27 stars 6 forks source link

Clarify relations of the java libraries #5

Closed constantinpape closed 1 year ago

constantinpape commented 1 year ago

Hi @carlosuc3m, great to see all the progress of the java libraries! For adoption, I think it would be very helpful to have some overview which libraries exist and how they relate to each other. I have created a small PR #4 to add this to the README (as far as I have an overview of the libraries), but I have two more questions:

carlosuc3m commented 1 year ago

Hello @constantinpape,

Is there any dependency on https://github.com/bioimage-io/core-bioimage-io-python left or are the new java libraries fully independent of it?

I guess you mean the Java one? https://github.com/bioimage-io/core-bioimage-io-java And no, they are completely independent. They are only in charge of converting the tensors and running the model.

What is the role of https://github.com/bioimage-io/tensorflow-2-java-interface-0.2.0?

It is an interface to deal with some changes introduced in version 0.2.0 of JAva Tensorflow. It has a couple of different classes. HOWever, I am looking to make a couple of workarounds to merge it with the other one and have a single tf2 library.

constantinpape commented 1 year ago

Hi @carlosuc3m,

I guess you mean the Java one? https://github.com/bioimage-io/core-bioimage-io-java And no, they are completely independent. They are only in charge of converting the tensors and running the model.

Yes I meant the java one, sorry. And good to know that they are independent. I guess we can then eventually deprecate https://github.com/bioimage-io/core-bioimage-io-java.

It is an interface to deal with some changes introduced in version 0.2.0 of JAva Tensorflow. It has a couple of different classes. HOWever, I am looking to make a couple of workarounds to merge it with the other one and have a single tf2 library.

Ok.

carlosuc3m commented 1 year ago

HEllo again, I am going to merge the branch that you created. I want to already finalize the first iteration of java-model-runner as soon as possible However,

Yes I meant the java one, sorry. And good to know that they are independent. I guess we can then eventually deprecate https://github.com/bioimage-io/core-bioimage-io-java.

I don't know whether to deprecate it or not, as it would be great to have a common library for working with rdf.yaml (reading and writting). Then all the Bioimage.io functionalities would be comprised in the two projects and using Bioimage.io models would not require any extra effort from a new consumer.

I think that it would be interesting to discuss this in the Hackaton (I already discussed this issue a little with @esgomezm)

carlosuc3m commented 1 year ago

Point to the readme https://github.com/bioimage-io/model-runner-java/edit/main/README.md