bioimage-io / bioimageio-uploader

1 stars 2 forks source link

Rename bioimage.yaml in "required file" text to "rdf.yaml" #32

Closed jmetz closed 8 months ago

jmetz commented 8 months ago

As decision on this renaming was to stick with original for now.

FynnBe commented 8 months ago

Wasn't the consensus to switch to bioimageio.yaml??

jmetz commented 8 months ago

😅 @oeway asked me to switch it back... I'll let you two discuss 🫣

oeway commented 8 months ago

Wasn't the consensus to switch to bioimageio.yaml??

No, if I remember correctly the concensus was to not touch it, see the last item in the meeting minutes here: https://github.com/bioimage-io/bioimage.io/issues/28#issuecomment-1802276877

FynnBe commented 8 months ago

ah, thanks, sorry for the confusion!

oeway commented 2 months ago

@FynnBe @mese79 mentioned:

Uploader expects a rdf.yaml file to be present in the model zip package, but the spec export functionality puts the model specs bioimageio.yaml file.

I thought you already changed back to rdf.yaml, could you confirm?

mese79 commented 2 months ago

Anyway, I've made a PR: https://github.com/bioimage-io/bioimageio-uploader/pull/93

FynnBe commented 2 months ago

I thought you already changed back to rdf.yaml, could you confirm?

I thought I had, but in fact there is still a preference of bioimageio.yaml over rdf.yaml I suppose... Made a PR to fix it in the next spec release: https://github.com/bioimage-io/spec-bioimage-io/pull/626

FynnBe commented 2 months ago

ah, I remember: I did change how the collection handles it, so that on bioimage.io it's all rdf.yaml... I suppose the PR would still be good to avoid confusion