bioimage-io / bioimageio-uploader

1 stars 2 forks source link

Validation issue with current format #44

Closed jmetz closed 8 months ago

jmetz commented 8 months ago

@FynnBe : when locally testing the validation workflow I get the following in the log:

{
  "ci_testing": [
    {
      "timestamp": "2024-02-08T13:48:59.494902",
      "log": "Adding a log at Thu  8 Feb 13:48:59 CET 2024"
    },
    {
      "timestamp": "2024-02-08T13:49:15.041834",
      "log": "Adding a log at Thu  8 Feb 13:49:14 CET 2024"
    }
  ],
  "validation_summaries": [
    {
      "timestamp": "2024-02-08T14:02:42.889513",
      "log": [
        {
          "bioimageio_spec_version": "0.4.9post5",
          "error": "Expected dict type for loaded source, but got: <class 'str'>. If 'uk1s3.embassy.ebi.ac.uk/public-datasets/sandbox.bioimage.io/willing-pig/files/rdf.yaml' is a file path, does it exist?",
          "name": "bioimageio.spec static validation of  RDF ",
          "nested_errors": {},
          "source_name": "uk1s3.embassy.ebi.ac.uk/public-datasets/sandbox.bioimage.io/willing-pig/files/rdf.yaml",
          "status": "failed",
          "traceback": [
            "  File \"/home/jeremy/.local/lib/python3.11/site-packages/bioimageio/spec/commands.py\", line 74, in validate\n    rdf_source_preview, source_name, root = resolve_rdf_source(rdf_source)\n                                            ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^\n",
            "  File \"/home/jeremy/.local/lib/python3.11/site-packages/bioimageio/spec/shared/_resolve_source.py\", line 193, in resolve_rdf_source\n    raise TypeError(\n"
          ],
          "warnings": {}
        }
      ]
    }
  ]
}

Any ideas? 
jmetz commented 8 months ago

Never-mind, I realized the url is wrong.

The validator expects the resource_path to include the version, but the rest of the workflows will look that up dynamically.