search

bioimage-io / bioimageio-uploader

1 stars 1 forks source link

Sandbox status page empty #85

Open jmetz opened 3 months ago

jmetz commented 3 months ago 
          > EDIT: Also @oeway will likely have to upgrade and restart the upload service for this to work.

I suppose that service restart has not happened yet.. status page looks like this rn:

image

Originally posted by @FynnBe in https://github.com/bioimage-io/bioimageio-uploader/issues/84#issuecomment-2089863923

jmetz commented 3 months ago

As suspected, this bug is due to a missing file:

https://uk1s3.embassy.ebi.ac.uk/public-datasets/sandbox.bioimage.io/collection_staged.json

does not exist, whereas:

https://uk1s3.embassy.ebi.ac.uk/public-datasets/bioimage.io/collection_staged.json

does exist.

@FynnBe - would you consider this a collection issue then?

jmetz commented 3 months ago

Note: @oeway + @FynnBe : even the non-sandbox page doesn't work from the preview, because deploy-preview-84--bioimageio-uploader.netlify.app is not in the allowed list for CORS on S3; in principle we'd have to add a wildcard-domain to that list like *bioimageio-uploader.netlify.app but as anyone can take a subdomain that ends with bioimageio-uploader, this would be considered bad practice in general.

Do you think I should temporarily allow that @oeway ? I could add eg deploy-preview-*--bioimageio-uploader.netlify.app.

jmetz commented 3 months ago

@oeway: temporarily added the above wildcard domain - in theory, as the top-level domain is still netlify this massively reduces the potential for misuse, and it may also be that netlify reserve deploy-preview* subdomains (though that's just a guess / wishful thinking perhaps :sweat_smile: ).

Let me know if you'd like me to turn that off again.

jmetz commented 3 months ago

Technically neither of the above issues (missing file on S3 and S3 CORS issue) are really directly related to this repo. but will leave this open until they're both resolved for anyone else who thinks to log this as an issue.