bioimage-io / bioimageio-uploader

1 stars 2 forks source link

open resource specific status page does not work with 'open in new tab' #87

Open FynnBe opened 4 months ago

FynnBe commented 4 months ago

when clicking on a resource in the overview page (https://bioimageio-uploader.netlify.app/#/status) the resource specific status page opens (should be the version specific status page, also): https://bioimageio-uploader.netlify.app/#/status/committed-turkey

when opnening the same link with 'open in new tab', the /# is missing and the page cannot be found: https://bioimageio-uploader.netlify.app/status/committed-turkey

jmetz commented 4 months ago

Am confused by 1) - it seems to me that going to the resource page is what would be wanted here?

For 2) perhaps prefixing all hrefs with # in the as could fix that, but I'm not 100% sure about that as it'll depend on what the router does. At the moment it intercepts a clicks to function correctly, hence the issue you're describing. "Proper" routes like https://bioimageio-uploader.netlify.app/status/committed-turkey can't work as it's a single-page-application.

jmetz commented 4 months ago

Can confirm that the fix for 1) works - see https://github.com/bioimage-io/bioimageio-uploader/commit/da5f94e90b1f5385e65731427acfb342c5135bb0