bioimage-io / bioimageio-uploader

1 stars 2 forks source link

Emoji assignment failure | Extra `nickname` in RDF file #92

Open qin-yu opened 5 months ago

qin-yu commented 5 months ago

Hey @oeway, Fynn is on holiday and I see you are the recent contributor so I'm bugging you here. I just tried to upload a model that passed local bioimageio.core.test_model. But there are three problems:

  1. The emoji doesn't show for it's name philosophical-panda.

    image

  2. While the CIs stage philosophical-panda #207 and test philosophical-panda draft #238 passes with green ticks, uploader shows nothing passed.

    image

  3. I think test philosophical-panda draft #238 skipped important tests.
oeway commented 5 months ago

Thanks for the report!

It looks like we have some bugs in the CI, it didn't report the right status to the uploader, since the uploader only displays a json file generated by the CI.

Will need @FynnBe to take a look.

qin-yu commented 4 months ago

Hi @oeway, for uploader-assigning-no-emoji error, I still have no clue; but for the CI failure, it was because the uploader tried to add nickname: xxx to RDF which is now redundant and should be removed (according to Fynn), and I guess this can only be solved from this repo. He just came back from holiday and is re-running my upload after manually removing the extra nickname line in RDF (so I don't @ him here).

qin-yu commented 4 months ago

Since we now know the cause of these issues, I changed the name here. Please note I have another comment above if you are viewing from mobile or using a webpage that doesn't update itself.

oeway commented 4 months ago

Hi @qin-yu thanks for looking into this, I have fixed it here: https://github.com/bioimage-io/bioimageio-uploader/commit/0fbf875ab39a342c692cccf43dc498d1f6979c9d

qin-yu commented 4 months ago

Thanks @oeway! There is another problem, specifically for my philosophical-panda, I tried to upload rdf.yaml with or without id_emoji: 🐼, my model gets undefined emoji in all cases.

qin-yu commented 4 months ago

The last time I tried was after your fix

0fbf875