search

bioimage-io / collection-bioimage-io

(deprecated in favor of bioimage-io/collection) RDF collection for BioImage.IO
5 stars 9 forks source link

Wrong model name #241

Closed constantinpape closed 2 years ago

constantinpape commented 2 years ago

The model name for https://github.com/bioimage-io/collection-bioimage-io/blob/main/collection/10.5281/zenodo.5817052/resource.yaml is wrong: this is not a mitochondria segmentation model, but a neuron segmentation model. See image

This looks pretty bad because it is the first model on the website and clearly wrong.... We could try fixing this on the fly by changing the name in the yaml in this repo or we need to update the version via the website / zenodo.

cc @esgomezm

esgomezm commented 2 years ago

Ups! I was confused with the data for the 3D UNet. I should be able to update it by clicking on the edit button, but I don't see the model on the webpage

constantinpape commented 2 years ago

Ups! I was confused with the data for the 3D UNet. I should be able to update it by clicking on the edit button, but I don't see the model on the webpage

Yes, @oeway is aware of that issue and currently fixing it.

oeway commented 2 years ago

@esgomezm could you try the preview version here: https://github.com/bioimage-io/bioimage.io/pull/228

esgomezm commented 2 years ago

So, the page works and I can click on edit, but then, i cannot update the model card, at the end of the process. It just allows me to upload a new deposit

oeway commented 2 years ago

So, the page works and I can click on edit, but then, i cannot update the model card, at the end of the process. It just allows me to upload a new deposit

OK, I will check that.

oeway commented 2 years ago

@esgomezm @constantinpape I just did a preliminary fix for the edit button, but I cannot test it since it requires existing items. could you try with 0.4.5 (refresh here: https://bioimage.io/#/about until you see 0.4.5)?

constantinpape commented 2 years ago

Yes, it's working now :).

oeway commented 2 years ago

@esgomezm and @constantinpape Do we have a plan on updating this model, I still see "mitochondria" in the model description.

constantinpape commented 2 years ago

As we discussed during the meeting @esgomezm wanted to check if update via the upload still works.

esgomezm commented 2 years ago

Hey! I'm trying model edition and it goes well until the update button but then it complains about a field called rdf_source. Screenshot 2022-01-26 at 14 43 41

Screenshot 2022-01-26 at 14 43 24

oeway commented 2 years ago

@esgomezm Thanks for the report, it should been fixed now in 0.4.7 (https://bioimage.io/#/about), please refresh the page and try it again.

esgomezm commented 2 years ago

Done! now should I see any PR?

constantinpape commented 2 years ago

Done! now should I see any PR?

Yes, I think it's this one: https://github.com/bioimage-io/collection-bioimage-io/pull/265

constantinpape commented 2 years ago

I have merged #265 and this is fixed now.