Add warning or more test when deleting content of model directory

bioinfomaticsCSU / deepsignal

Detecting methylation using signal-level features from Nanopore sequencing reads

GNU General Public License v3.0

109 stars 21 forks source link

Add warning or more test when deleting content of model directory #14

Closed pterzian closed 5 years ago

pterzian commented 5 years ago

Hi there,

I'm opening this issue because I think these lines in the train_model.py file might be dangerous.

The first time I used this script I wanted to save the custom model at the root of my deepsignal working directory so I set --model_dir value to . and it did delete everything in my current folder without any explanation (hopefully I recovered everything).

Best, Paul

PengNi commented 5 years ago

Hi Paul,

It is dangerous indeed. Sorry we didn't think of it before and make you in unnecessary trouble. We will patch it ASAP.

Best, Peng

PengNi commented 5 years ago

See 382585e.