search

bioinform / ecTMB

Other
19 stars 10 forks source link

Bug in fit_model #6

Closed a-jartseva closed 3 years ago

a-jartseva commented 4 years ago

Hello,

I found a bug in the fit_model function, which only reveals itself if one tries to use some other name for the trainset variable.

Here: https://github.com/bioinform/ecTMB/blob/abf9b3722b3688ac9857bbf3b3166ee3fc8a3ed1/R/stats.R#L412-L417 Instead of trainset in the CalTMB function calls (both the first argument and the sampleN), the argument should be Data, so that it refers to the argument specified in the fit_model function call.

It will be great if you fix it in the next release!

Best wishes, Aleksandra

lijingya commented 3 years ago

Thanks. It is fixed.

Best Lijing