search

bioinformagic / monica

MinION Open Nucleotide Identifier for Continuous Analysis - an open source pathogen identifier for real-time analysis on MinION output
8 stars 0 forks source link

more pythonic #7

Open lfaino opened 5 years ago

lfaino commented 5 years ago

https://github.com/bioinformagic/monica/blob/03ba4b767ab35648df38028c0b6050ca9f216a2b/libs/GoodOvernight.py#L46

Dear @DrQuestion and @simozhou , this way of doing the parallel jobs is not the one that i prefer. please have a look at multiprocess library of python. Parallel is a bit problematic some times.

Cheers Luigi

simozhou commented 5 years ago

fixed subprocess.call with our project-native shell_runner.

We need to fix pooling with multiprocessing and some other TODOs that I left in the code in my last commit.