bioio-devs / bioio-ome-zarr

A BioIO reader plugin for reading Zarr files in the OME format.

BSD 3-Clause "New" or "Revised" License

0 stars 2 forks source link

Update test ZARR path #24

Closed pgarrison closed 3 months ago

pgarrison commented 3 months ago

Context

One test uses real (i.e., not specifically for testing) data. The scientific project publishing the data has moved the file from the nuc_morph_data folder to the nuc-morph-dataset folder. The new location is visible here on quilt. The file at the old path will soon be removed.

Change

Update the path in the test.

Testing

pytest bioio_ome_zarr/tests/test_s3_read.py

pgarrison commented 3 months ago

Test failures in CI appear unrelated. The test I touched is passing in CI.

toloudis commented 3 months ago

Test failures in CI appear unrelated. The test I touched is passing in CI.

We need to get the unit tests back to green asap or else remove them completely. I think a prior PR in here will fix them but is waiting for a bioio-base version bump first.

pgarrison commented 3 months ago

Merged #25 into this branch (I probably should have waited to merge this one first)

pgarrison commented 3 months ago

Merged #25 into this branch (I probably should have waited to merge this one first)

Undid this with a force push so this PR is now simple again