biojava / biojava-tutorial

:book::books:An introductory tutorial for BioJava
http://www.biojava.org
Other
118 stars 42 forks source link

Multiple Structure Alignment Example doesn't work #14

Closed pwrose closed 7 years ago

pwrose commented 7 years ago

--> should this line read: MultipleAlignment result = multiple.align(atomArrays);

--> after fixing the previous statement, the toFASTA method throws an exception.

lafita commented 7 years ago

The classes that use Jmol were renamed to contain Jmol in its name, so this class is now called MultipleAlignmentJmolDisplay. I will update the example and also fix the type with algorithm/multiple.

I would recommend that you use the DemoMultipleMC classes inside the demo package in both the biojava-structure and the biojava-structure-gui modules, since they are up to day and should work without errors.

Thank you for reporting the errors in the example.

lafita commented 7 years ago

The toFASTA method was throwing a NullPointer because the StructureIdentifiers were not set in the example, so the headers of the FASTA alignment format were null. It is fixed now.