search

biojppm / rapidyaml

Rapid YAML - a library to parse and emit YAML, and do it fast.
MIT License
583 stars 100 forks source link

chore: Add support for Python 3.12 #392

Closed mboutet closed 1 year ago

mboutet commented 1 year ago

Really not sure that it's the only thing I need to do to support Python 3.12 😛

Fixes https://github.com/biojppm/rapidyaml/issues/391

codecov[bot] commented 1 year ago

Codecov Report

Merging #392 (c9f3f53) into master (2cf09b0) will not change coverage. The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #392   +/-   ##
=======================================
  Coverage   96.59%   96.59%           
=======================================
  Files          22       22           
  Lines        8155     8155           
=======================================
  Hits         7877     7877           
  Misses        278      278

:mega: Codecov offers a browser extension for seamless coverage viewing on GitHub. Try it in Chrome or Firefox today!

mboutet commented 1 year ago

@biojppm, sorry for the ping, but any chance you can approve the workflows so they can run?

mboutet commented 1 year ago

I'm not sure if the failures in the CI are due to my changes. The failure for the samples workflow appears to be caused by the workflow trying to checkout commit https://github.com/biojppm/rapidyaml/pull/392/commits/c9f3f53817e08a6a7f2264dd14de6a6a0c9db0df which is from my fork rather than your repository.

The following: https://github.com/biojppm/rapidyaml/blob/2cf09b073db1921938f7db87cb74560512829f55/samples/fetch_content/CMakeLists.txt#L17

should be updated to support cloning from the forked repository of a given PR.

biojppm commented 1 year ago

Thanks for your work!