biojppm
commented
5 months ago I can't reproduce at all, and the YAML you provided is parsing correctly in my linux machine. Your report is confusing, and missing fundamental information:
- The stream code is not helpful, as there are differences between platforms, and the pesky
std::ios::binarysituation. Stick to using eitherstd::stringorcsubstrorconst char*, containing all the characters (see example below) - You make reference to line 7, but your YAML has only 6 lines.
- Paste the exact error message for the YAML that is being parsed.
Please provide a minimum verifiable example, with the exact YAML source embedded as a string in C++ code. Otherwise, I can't help you.
FWIW, this is what I tried:
void test_439(csubstr yaml)
{
test_check_emit_check(yaml, [](Tree const &t){
ConstNodeRef n = t["meta"];
EXPECT_EQ(n["title"], "Croft Arena");
EXPECT_EQ(n["author"], "JaayStation, SOTOS");
EXPECT_EQ(n["downloadSoundtrack"], "false");
EXPECT_EQ(n["urls"][0].val(), "https://drive.google.com/file/d/1fJ1Z3Ktr2VlPK1MD5OB4tY7uDnqyRMEQ/view?usp=sharing");
});
}
void test_439_ostream(csubstr yaml)
{
{
std::ofstream ofile("adsasd.bin", std::ios::out | std::ios::binary);
ofile.write(yaml.str, (std::streamsize)yaml.len);
}
std::vector<char> m_buffer;
{
std::ifstream file("adsasd.bin", std::ios::in | std::ios::binary);
ASSERT_TRUE(file.is_open());
file.seekg(0, std::ios::end);
const std::streamsize size = static_cast<std::streamsize>(file.tellg());
file.seekg(0, std::ios::beg);
m_buffer.resize((size_t)size);
file.read(&m_buffer[0], size);
}
EXPECT_EQ(to_csubstr(m_buffer), yaml);
test_439(to_csubstr(m_buffer));
// try with trailing \0
m_buffer.resize(m_buffer.size() + 10);
EXPECT_TRUE(to_csubstr(m_buffer).last(10).trim('\0').empty());
std::cout << to_csubstr(m_buffer);
test_439(to_csubstr(m_buffer));
}
TEST(github, 439_0)
{
csubstr yaml = ""
"meta:\n"
" title: \"Croft Arena\"\n"
" author: \"JaayStation, SOTOS\"\n"
" downloadSoundtrack: false\n"
" urls:\n"
" - \"https://drive.google.com/file/d/1fJ1Z3Ktr2VlPK1MD5OB4tY7uDnqyRMEQ/view?usp=sharing\"\n";
test_439(yaml);
test_439_ostream(yaml);
}
TEST(github, 439_1)
{
csubstr yaml = ""
"meta:\r\n"
" title: \"Croft Arena\"\r\n"
" author: \"JaayStation, SOTOS\"\r\n"
" downloadSoundtrack: false\r\n"
" urls:\r\n"
" - \"https://drive.google.com/file/d/1fJ1Z3Ktr2VlPK1MD5OB4tY7uDnqyRMEQ/view?usp=sharing\"\r\n";
test_439(yaml);
test_439_ostream(yaml);
}
stohrendorf
This is the code which loads the YAML:
This is the YAML is should parse, including a newline at the end:
However, in version 0.7.0, rapidyaml throws an error that it's missing a colon after the key at line 7, column 2, which is an empty line, and beyond the size of the buffer. It works fine with 0.6.0, so I'm wondering if there's a breaking change regarding the new parser I don't fully grasp, or if it's an actual bug regarding handling of null terminators. When I remove the
std::ios::binary, it complains about column 7, which indicates the latter, as the file has 7 lines with\r\nterminators, and the debugger showed me that the buffer contained only plain\n's.