search

biojs / biojs-backend

Backend repository for biojs.net website.
MIT License
1 stars 3 forks source link

Tests #22

Closed Megh-Thakkar closed 6 years ago

Megh-Thakkar commented 6 years ago

Test for Detail Components view

Megh-Thakkar commented 6 years ago

@rowlandm that does sound like a good idea! I will incorporate the same as soon as possible and then we can merge this PR.

rowlandm commented 6 years ago

Remember that you should use >= for some/most of your checks

eg. commits >= 50 as the values should be the same or higher, shouldn't get lower number of commits in the future.

On Sun, Jun 10, 2018 at 6:15 PM Megh Thakkar notifications@github.com wrote:

@rowlandm https://github.com/rowlandm that does sound like a good idea! I will incorporate the same as soon as possible and then we can merge this PR.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/biojs/biojs-backend/pull/22#issuecomment-396030247, or mute the thread https://github.com/notifications/unsubscribe-auth/AAZo0jwEr0ofHYWumO8ATo6o8DxuD18Eks5t7NWJgaJpZM4Uhn0v .

Megh-Thakkar commented 6 years ago

@rowlandm I have updated the tests for the Github API call.

I also added another test to make sure that the 'modified_time' is not before 'created_time'. The test script is incorporated into the .travis.yml file and they have passed according to the repository you specified.

Megh-Thakkar commented 6 years ago

@rowlandm I was going through some documentation of Github. I think if the user deletes a forked repository, the number of forks go down. It goes parallel for number of stars and watchers as well. Hence, I only set up the test for number of commits.

Please correct me if I am wrong about the number of forks.

Thanks.

Megh-Thakkar commented 6 years ago

Hey @rowlandm can this be merged now as we discussed these changes? Thanks!

rowlandm commented 6 years ago

Sure thing.

El dom., 10 de jun. de 2018 20:17, Megh Thakkar notifications@github.com escribió:

Hey @rowlandm https://github.com/rowlandm can this be merged now as we discussed these changes? Thanks!

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/biojs/biojs-backend/pull/22#issuecomment-396037539, or mute the thread https://github.com/notifications/unsubscribe-auth/AAZo0lfTJHwyGhOYSxFkJuR3HpHFpkZRks5t7PI6gaJpZM4Uhn0v .

sarthak-sehgal commented 6 years ago

@rowlandm could you please approve the changes? Merging is blocked.