search

biojs / biojs-backend

Backend repository for biojs.net website.
MIT License
1 stars 3 forks source link

[F] New paginated components route #48

Closed DennisSchwartz closed 5 years ago

DennisSchwartz commented 5 years ago

This will be used by the frontend for infinite component scroll. It's not affecting any existing functionality.

yochannah commented 5 years ago

To test the endpoint, should I GET something like http://localhost:8000/components?page=1&size=40 ?

DennisSchwartz commented 5 years ago

@yochannah Yes that get request should work. You can also run it together with this: https://github.com/biojs/biojs-frontend/pull/63 To see the effect in the frontend.

DennisSchwartz commented 5 years ago

Docs: Could you add instructions how to enable and disable logging? Apologies if I've missed it somewhere

Could do, at the moment it's disabled like it was before, but you can enable it manually during development, so I didn't bother with a README entry.

Docs again: GITHUB_CLIENT_SECRET and ID - presumably users should set these somewhere - can we write down where?

This one is a bit tricky, I'm using a personal Github access token for development. But I agree, I will add some docs for that.

It would be a little easier in the future to work with a forked branch rather than develop on the main repo, but this should be fine for now.

Yep, but I got confused by the develop and master branches and they weren't in the proper states anyway. I'll introduce a bit of a different branch structure (that I think is more commonly used) once I add the automated deployment.

DennisSchwartz commented 5 years ago

@yochannah I've added documentation for your points 1. and 2.

yochannah commented 5 years ago

@DennisSchwartz The docs look great! <3 nice one.

I'm trying to preview on http://dev.biojs.net/?#/components - is that where I should see infinite scroll? Tried on FF and Chrome but nothing happens at the end of the page.

DennisSchwartz commented 5 years ago

@yochannah Well the infinite scroll is not deployed on dev in the frontend yet, because it's still a PR (https://github.com/biojs/biojs-frontend/pull/63) but I'm just gonna merge that one now haha.

yochannah commented 5 years ago

sounds fine by me! Sorry I had so much trouble testing it :)

On Fri, 4 Jan 2019 at 15:49, Dennis Schwartz notifications@github.com wrote:

@yochannah https://github.com/yochannah Well the infinite scroll is not deployed on dev in the frontend yet, because it's still a PR ( biojs/biojs-frontend#63 https://github.com/biojs/biojs-frontend/pull/63) but I'm just gonna merge that one now haha.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/biojs/biojs-backend/pull/48#issuecomment-451481883, or mute the thread https://github.com/notifications/unsubscribe-auth/AI14jpin8BlZapT2b_2i8aQCxdl2Y3WSks5u_3gKgaJpZM4ZneRn .