search

biojs / generator-biojs-webcomponents

Generate all the boilerplate for your next BioJS tool!
http://training.biojs.net
MIT License
9 stars 2 forks source link

If version requested for npm package is 'latest', we don't need to verify if version is valid as it is always valid. #26

Open Nikhil-Vats opened 5 years ago

Nikhil-Vats commented 5 years ago

Description

When we import build file from npm, we ask the user for package name and version. In most cases, the version requested will be latest and if it is latest we don't need to verify it exists because it always does.

Steps to Reproduce

Use the generator and when generator asks for version just press enter (as latest is default) or enter latest, it will take time to show you the next prompt because it will verify the version.

Expected Behaviour

The generator should not check for the version if it is latest.

Actual Behaviour

The generator unnecessarily checks whether version is valid or not and this takes time.

sarthak-sehgal commented 5 years ago

@Nikhil-Vats can this issue be closed?

Nikhil-Vats commented 5 years ago

No. It's an easy fix. I will mostly fix this in this week.