search

biojs / generator-biojs-webcomponents

Generate all the boilerplate for your next BioJS tool!
http://training.biojs.net
MIT License
9 stars 2 forks source link

Fixed - Do not check for version if user enters latest #37

Closed Nikhil-Vats closed 4 years ago

Nikhil-Vats commented 4 years ago

Description

If the version is latest, the generator does need not check if its valid as latest automatically means the latest version on npm. This saves time.

Related issues and discussion

26

Screenshots, if any

Checklist

Please make sure these boxes are checked before submitting your pull request - thanks!

sarthak-sehgal commented 4 years ago

Nice!

sarthak-sehgal commented 4 years ago

@Nikhil-Vats is the check for the term “latest” case sensitive? 🤔

Nikhil-Vats commented 4 years ago

Yes @sarthak-sehgal, the npm view command works only if version is "latest", it is case sensitive and the code checks that.

sarthak-sehgal commented 4 years ago

I feel that it should be case insensitive. Sorry about not mentioning it earlier!

sarthak-sehgal commented 4 years ago

Merging for now as this is blocking release of a new version. Raised #38