search

biojs / organisation

A hub for organising the community and ourselves
2 stars 1 forks source link

Text overflow at various places in biojs.io #26

Closed sarthak-sehgal closed 6 years ago

sarthak-sehgal commented 6 years ago

Issue

The text is exceeding the circle boundary as you can see here: biojs issue 1

Suggested fix

A circle will either grow bigger to adjust the text or we will have to decrease the text size. Neither of the solutions seems to be a good fix. I suggest that the UI should be something like this: biojs issue solve 1

And, in fact, the background should be in contrast with the white colored text. So I suggest to make the background a bit darker and the text bolder as in: biojs issue solve 2

sarthak-sehgal commented 6 years ago

@yochannah @rowlandm Would like to work on this if this is an appropriate issue.

rowlandm commented 6 years ago

I like the darker background colour.

That's fine to work on Sarthak.

fireballpoint1 commented 6 years ago

How about doing a round off like 18k for the first case and we can put the real value on hover? @rowlandm We can retain the disc background in that case

sarthak-sehgal commented 6 years ago

@fireballpoint1, I think putting numbers (or something else dynamic) in a circle is never a good idea. If you round it off, it will create an issue when it further increases (e.g.: 100k). Also, I suggested the change in the background color to increase the contrast with the text color so anyhow we will have to change it. :)

abhinavvisen commented 6 years ago

@sarthak-sehgal @rowlandm how about instead of notifying the number of downloads ,can we go with the dynamic popups.

rowlandm commented 6 years ago

Welcome @abhinavvisen

Sorry - I'm not quite sure what you mean there?

Did you mean hover over?

abhinavvisen commented 6 years ago

@rowlandm Yes i was thinking of that. By the way sorry for late response.:) I am working on a mockup right now.It will be clear when i am done with it.