search

biojs / registry-ui

OLD BioJS registry frontend. For new repo, see https://github.com/biojs/biojs-frontend
https://github.com/biojs/biojs-frontend
7 stars 9 forks source link

fix detail view of ProtVista component and initiate protractor tests #25

Closed jayjayjpg closed 8 years ago

jayjayjpg commented 8 years ago

@emepyc @4ndr01d3 @ljgarcia @wilzbach Please review and merge to stable if this looks suitable: dev.biojs.io

jayjayjpg commented 8 years ago

@ljgarcia @emepyc @4ndr01d3 Hey everyone, I'd like to merge this tonight to fix the bug with the display of the ProtVista component in our registry. Please object if you find any issues in this PR that speak against a merge

ljgarcia commented 8 years ago

Hi Jessica, although I was not able to perform an in-depth code review, the pages are working fine for me. As some changes are related to styling and other visual stuff, for the future, I would suggest to include an example to check for reviewers (particularly for those of us not well familiar with the code).

jayjayjpg commented 8 years ago

@ljgarcia Thanks for the feedback! The code can by the way be checked without any local installation anytime on http://dev.biojs.io where the gh-pages branch is deployed (see also in the README). I already merged all the changes from this PR to this gh-pages branch so anyone is free to test it there

EDIT: Ah sorry, I now get it! I'll attach a couple of screenshots next time, that's a good point especially for the visual changes!