biojs / registry-ui

OLD BioJS registry frontend. For new repo, see https://github.com/biojs/biojs-frontend
https://github.com/biojs/biojs-frontend
7 stars 9 forks source link

Logo.png in repository #6

Closed mpschr closed 9 years ago

mpschr commented 9 years ago

Hi

Just general input: I think it would be nice if a repository could define a logo.png or something similar which will then be shown rather than the repository owner image.

wilzbach commented 9 years ago

For a very short time we experimented with automatically generated screenshots, but we had some issues with phantomjs.

if a repository could define a logo.png

+1 - what about having a field in the package.json like screenshot or thumbnail?

mpschr commented 9 years ago

That would be a good solution, using package.json. Some may have interest to prepare a nice image with additional legends/explanation rather than a screenshot in initialization state.

A side question: is the package.json free format?

wilzbach commented 9 years ago

Yep it is, but there is the risk of creating conflicts with other services. However I don't think that anyone else will use the key "thumbnail" or "screenshot" for something different, so this should be fine :)

Has anyone a personal preference over one of the suggested keys : "screenshot", "thumbnail"? I would suggest to use the singular as in most cases only one thumbnail is enough - the registry could accept also an array (and if wanted check for the plural with 's').

mpschr commented 9 years ago

Singular is fine and screenshot is clear. I don't know what exactly you'd expect with thumbnail - a small version of the screenshot?

Personally, I'd like to have the ability to specifiy logo.

mhelvens commented 9 years ago

I'd say that namespace conflicts are a definite concern. It seems impolite to claim a bunch of common nouns for BioJS. There may be agreed upon standards for top-level keys in package.json. Otherwise, I'd say you should only use a top level biojs key, and house everything else under that key.

emepyc commented 9 years ago

I would say that "screenshot" is a bit limited. Using a project logo or something like this is another use of this.

wilzbach commented 9 years ago

It seems impolite to claim a bunch of common nouns for BioJS

+1

@mpschr I think we are talking about two different things. You want to change the user avatar with a custom logo? Then I think avatar is best?

@emepyc Instead of an automatic generated screenshot the user could provide one (or multiple) screenshots that will be displayed on the registry (as part of the current table view) - this is could be very nice for the card view, too. However then we should also agree on a thumbnail size like 600x400 or 800x600 - I think for now it is a total overkill to specify different thumbnail sizes ...

mpschr commented 9 years ago

@greenify Ah yeah I was talking about the avatars. The logo would be for those who prefer to put their software logo instead of their personal avatar. This way you could chose, and if nothing is provided the avatar is there.

wilzbach commented 9 years ago

@mpschr just add this config to your package.json - maybe I find some free time over the weekend ;-)

"biojs": {
   "logo": "<path>"
}
mpschr commented 9 years ago

Ok, I've included it. Let's see if it appears some time ;-)

Best

wilzbach commented 9 years ago

The registry appends "logo.png" if no file extension is given ;-)

So I close this issue as this was only about the avatar / logo