biolab / orange-canvas-core

Orange Canvas core workflow editor
GNU General Public License v3.0
36 stars 62 forks source link

[FIX] Fix error on link create #220

Closed ales-erjavec closed 2 years ago

ales-erjavec commented 2 years ago

When in open anchors mode dragging a outgoing link back onto the node itself would raise an:

ValueError: min() arg is an empty sequence

in AnchorItem.signalAtPos

---------------------------- ValueError Exception -----------------------------
Traceback (most recent call last):
  File "/home/ales/devel/orange-canvas-core/orangecanvas/canvas/scene.py", line 848, in mouseReleaseEvent
    self.user_interaction_handler.mouseReleaseEvent(event):
  File "/home/ales/devel/orange-canvas-core/orangecanvas/document/interactions.py", line 610, in mouseReleaseEvent
    sink_signal = item.inputAnchorItem.signalAtPos(
  File "/home/ales/devel/orange-canvas-core/orangecanvas/canvas/items/nodeitem.py", line 1024, in signalAtPos
    return min(signalsToFind, key=signalLengthToPos)
ValueError: min() arg is an empty sequence
-------------------------------------------------------------------------------

link-error

codecov-commenter commented 2 years ago

Codecov Report

Merging #220 (f030783) into master (f8f944c) will increase coverage by 0.00%. The diff coverage is 25.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #220   +/-   ##
=======================================
  Coverage   74.03%   74.03%           
=======================================
  Files          95       95           
  Lines       20267    20272    +5     
=======================================
+ Hits        15004    15008    +4     
- Misses       5263     5264    +1     
Impacted Files Coverage Δ
orangecanvas/document/interactions.py 41.74% <25.00%> (-0.11%) :arrow_down:
orangecanvas/utils/overlay.py 79.95% <0.00%> (+0.40%) :arrow_up:
orangecanvas/gui/dock.py 79.84% <0.00%> (+0.77%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update f8f944c...f030783. Read the comment docs.