biolab / orange-canvas-core

Orange Canvas core workflow editor
GNU General Public License v3.0
36 stars 62 forks source link

[FIX] Set default application level window icon #256

Closed ales-erjavec closed 1 year ago

ales-erjavec commented 1 year ago

Issue

Orange installed from conda/pip does not have an icon (on Mac)

Fixes: https://github.com/biolab/orange3/issues/6129

Changes

Set default application level window icon (special care must be taken so the default application icon does not override the "proxy icon" for file in the main window).

codecov-commenter commented 1 year ago

Codecov Report

Base: 74.75% // Head: 74.73% // Decreases project coverage by -0.02% :warning:

Coverage data is based on head (60fbe8a) compared to base (b063d20). Patch coverage: 22.22% of modified lines in pull request are covered.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #256 +/- ## ========================================== - Coverage 74.75% 74.73% -0.03% ========================================== Files 96 96 Lines 20606 20619 +13 ========================================== + Hits 15405 15409 +4 - Misses 5201 5210 +9 ``` | [Impacted Files](https://codecov.io/gh/biolab/orange-canvas-core/pull/256?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=biolab) | Coverage Δ | | |---|---|---| | [orangecanvas/main.py](https://codecov.io/gh/biolab/orange-canvas-core/pull/256?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=biolab#diff-b3JhbmdlY2FudmFzL21haW4ucHk=) | `81.96% <0.00%> (-0.27%)` | :arrow_down: | | [orangecanvas/application/canvasmain.py](https://codecov.io/gh/biolab/orange-canvas-core/pull/256?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=biolab#diff-b3JhbmdlY2FudmFzL2FwcGxpY2F0aW9uL2NhbnZhc21haW4ucHk=) | `69.65% <25.00%> (-0.27%)` | :arrow_down: | | [orangecanvas/document/usagestatistics.py](https://codecov.io/gh/biolab/orange-canvas-core/pull/256?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=biolab#diff-b3JhbmdlY2FudmFzL2RvY3VtZW50L3VzYWdlc3RhdGlzdGljcy5weQ==) | `64.38% <0.00%> (-0.27%)` | :arrow_down: | Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=biolab). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=biolab)

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.