Closed janezd closed 1 year ago
Base: 74.73% // Head: 74.76% // Increases project coverage by +0.03%
:tada:
Coverage data is based on head (
2c9209d
) compared to base (2eab65f
). Patch coverage: 94.59% of modified lines in pull request are covered.
:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.
@ales-erjavec, thank you. Is it done? Can I review and merge?
Yes
Channels have names (for humans) and ids (for machines).
A workflow created in English version of Orange cannot be loaded in Slovenian Orange because channel names are translated. This change fixes that by using id's, which are not translated. This change will have effect after https://github.com/biolab/orange-widget-base/pull/229 is merged.
I think using id's in .ows is also better in principle.
For backward compatibility,
input_channel
andoutput_channel
match by id and, as a fallback, by name. This will fail if id is the same as the name of another signal, which is unlikely. Besides, https://github.com/biolab/orange-widget-base/pull/229 shows a warning in such cases.