biolab / orange-canvas-core

Orange Canvas core workflow editor
GNU General Public License v3.0
33 stars 60 forks source link

Add `LazyValue`s #259

Closed janezd closed 1 year ago

janezd commented 1 year ago

Ref. https://github.com/biolab/orange3/issues/5720.

See description in the code.

Also see changes in https://github.com/biolab/orange-widget-base/pull/232.

Usage example is shown in https://github.com/biolab/orange3/pull/6348.

This assumes that signal manager does not check that the type of the signal matches the defined type - as is currently the case. Should it ever check this, it will have to recognize lazy signals in check their wrapped types.

codecov-commenter commented 1 year ago

Codecov Report

Base: 74.73% // Head: 74.79% // Increases project coverage by +0.06% :tada:

Coverage data is based on head (c5e180e) compared to base (26b1446). Patch coverage: 97.05% of modified lines in pull request are covered.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #259 +/- ## ========================================== + Coverage 74.73% 74.79% +0.06% ========================================== Files 96 96 Lines 20621 20688 +67 ========================================== + Hits 15411 15474 +63 - Misses 5210 5214 +4 ``` | [Impacted Files](https://codecov.io/gh/biolab/orange-canvas-core/pull/259?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=biolab) | Coverage Δ | | |---|---|---| | [orangecanvas/scheme/signalmanager.py](https://codecov.io/gh/biolab/orange-canvas-core/pull/259?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=biolab#diff-b3JhbmdlY2FudmFzL3NjaGVtZS9zaWduYWxtYW5hZ2VyLnB5) | `88.57% <97.05%> (+0.57%)` | :arrow_up: | | [orangecanvas/gui/dock.py](https://codecov.io/gh/biolab/orange-canvas-core/pull/259?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=biolab#diff-b3JhbmdlY2FudmFzL2d1aS9kb2NrLnB5) | `79.06% <0.00%> (-0.78%)` | :arrow_down: | | [orangecanvas/scheme/node.py](https://codecov.io/gh/biolab/orange-canvas-core/pull/259?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=biolab#diff-b3JhbmdlY2FudmFzL3NjaGVtZS9ub2RlLnB5) | `84.76% <0.00%> (+0.63%)` | :arrow_up: | | [orangecanvas/scheme/readwrite.py](https://codecov.io/gh/biolab/orange-canvas-core/pull/259?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=biolab#diff-b3JhbmdlY2FudmFzL3NjaGVtZS9yZWFkd3JpdGUucHk=) | `73.21% <0.00%> (+1.24%)` | :arrow_up: | Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=biolab). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=biolab)

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.