biolab / orange-canvas-core

Orange Canvas core workflow editor
GNU General Public License v3.0
36 stars 62 forks source link

Category discovery: Improve logic for determining category name #267

Closed janezd closed 1 year ago

janezd commented 1 year ago

This PR changes the resolving the category name to follow this order,

Previously, the first two points were reversed. I think package globals should have precedence because they are explicit.

Besides, the entry point is always defined (has to be, AFAIK), so the name from package globals was ignored. As result, we couldn't translate category names.

codecov-commenter commented 1 year ago

Codecov Report

Patch coverage: 26.66% and project coverage change: -0.04 :warning:

Comparison is base (61fe8c1) 74.91% compared to head (52b800a) 74.88%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #267 +/- ## ========================================== - Coverage 74.91% 74.88% -0.04% ========================================== Files 97 97 Lines 20696 20705 +9 ========================================== Hits 15504 15504 - Misses 5192 5201 +9 ``` | [Impacted Files](https://codecov.io/gh/biolab/orange-canvas-core/pull/267?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=biolab) | Coverage Δ | | |---|---|---| | [orangecanvas/registry/discovery.py](https://codecov.io/gh/biolab/orange-canvas-core/pull/267?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=biolab#diff-b3JhbmdlY2FudmFzL3JlZ2lzdHJ5L2Rpc2NvdmVyeS5weQ==) | `38.28% <15.38%> (-0.97%)` | :arrow_down: | | [orangecanvas/registry/utils.py](https://codecov.io/gh/biolab/orange-canvas-core/pull/267?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=biolab#diff-b3JhbmdlY2FudmFzL3JlZ2lzdHJ5L3V0aWxzLnB5) | `93.65% <100.00%> (-0.10%)` | :arrow_down: | Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=biolab). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=biolab)

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.