search

biolab / orange-canvas-core

Orange Canvas core workflow editor
GNU General Public License v3.0
33 stars 60 forks source link

[ENH] editlinksdialog: Replace hardcoded colors with palette derived ones #269

Closed ales-erjavec closed 1 year ago

ales-erjavec commented 1 year ago

Issue

The Edit Links dialog has bad contrast with dark style.

Changes

Replace hardcoded colors with palette derived ones.

Before: Screenshot_20230503_123350 After: Screenshot_20230503_123456

codecov-commenter commented 1 year ago

Codecov Report

Patch coverage: 95.00% and project coverage change: +0.10 :tada:

Comparison is base (e984ff5) 74.95% compared to head (5293b4a) 75.06%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #269 +/- ## ========================================== + Coverage 74.95% 75.06% +0.10% ========================================== Files 97 97 Lines 20726 20766 +40 ========================================== + Hits 15536 15587 +51 + Misses 5190 5179 -11 ``` | [Impacted Files](https://app.codecov.io/gh/biolab/orange-canvas-core/pull/269?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=biolab) | Coverage Δ | | |---|---|---| | [orangecanvas/document/editlinksdialog.py](https://app.codecov.io/gh/biolab/orange-canvas-core/pull/269?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=biolab#diff-b3JhbmdlY2FudmFzL2RvY3VtZW50L2VkaXRsaW5rc2RpYWxvZy5weQ==) | `79.50% <95.00%> (+3.87%)` | :arrow_up: | ... and [1 file with indirect coverage changes](https://app.codecov.io/gh/biolab/orange-canvas-core/pull/269/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=biolab)

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.