biolab / orange-canvas-core

Orange Canvas core workflow editor
GNU General Public License v3.0
33 stars 60 forks source link

[FIX] nodeitem: Update opened anchor on link completion #284

Closed ales-erjavec closed 9 months ago

ales-erjavec commented 9 months ago

Issue

When Shift dragging a new connection from an expanded channel anchor to an empty spot on the canvas and not completing the interaction (i.e. canceling it) then the connection anchor remains open.

Similar to gh-272 except that the connection needs to be dragged to an empty spot and then closing the new node menu.

Changes

Update anchor positions when changing state.

codecov-commenter commented 9 months ago

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (7f535af) 75.47% compared to head (bf632ce) 75.66%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #284 +/- ## ========================================== + Coverage 75.47% 75.66% +0.19% ========================================== Files 99 99 Lines 21033 21034 +1 ========================================== + Hits 15875 15916 +41 + Misses 5158 5118 -40 ``` | [Files](https://app.codecov.io/gh/biolab/orange-canvas-core/pull/284?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=biolab) | Coverage Δ | | |---|---|---| | [orangecanvas/canvas/items/nodeitem.py](https://app.codecov.io/gh/biolab/orange-canvas-core/pull/284?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=biolab#diff-b3JhbmdlY2FudmFzL2NhbnZhcy9pdGVtcy9ub2RlaXRlbS5weQ==) | `86.49% <0.00%> (+0.11%)` | :arrow_up: | ... and [4 files with indirect coverage changes](https://app.codecov.io/gh/biolab/orange-canvas-core/pull/284/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=biolab)

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.