search

biolab / orange-canvas-core

Orange Canvas core workflow editor
GNU General Public License v3.0
33 stars 60 forks source link

[ENH] Remove use of pkg_resources #289

Closed ales-erjavec closed 7 months ago

ales-erjavec commented 8 months ago

Issue

pkg_resources is deprecated.

Changes

Remove/replace use of pkg_resources with importlib.metadata, importlib.resources, pkgutil and packaging.

This also bumps version to 0.2.* because it is backwards incompatible due to differences in exposed types in the discovery process. This should trigger the orange-canvas-core>=0.1.30,<0.2a condition in https://github.com/biolab/orange3/blob/78f7b30a89a7b78ef6442f0b828f41a6f5c27951/requirements-gui.txt#L1

codecov-commenter commented 8 months ago

Codecov Report

Attention: 28 lines in your changes are missing coverage. Please review.

Comparison is base (cbf2e9a) 75.57% compared to head (8018377) 76.47%. Report is 2 commits behind head on master.

Files Patch % Lines
orangecanvas/application/examples.py 50.00% 8 Missing :warning:
orangecanvas/help/manager.py 64.70% 6 Missing :warning:
orangecanvas/application/addons.py 37.50% 5 Missing :warning:
orangecanvas/application/utils/addons.py 84.00% 4 Missing :warning:
orangecanvas/registry/discovery.py 71.42% 2 Missing :warning:
orangecanvas/styles/__init__.py 66.66% 2 Missing :warning:
orangecanvas/document/interactions.py 50.00% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #289 +/- ## ========================================== + Coverage 75.57% 76.47% +0.90% ========================================== Files 99 99 Lines 21047 21031 -16 ========================================== + Hits 15906 16084 +178 + Misses 5141 4947 -194 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

PrimozGodec commented 7 months ago

LGTM. It is a lot, so I hope I didn't miss anything. I tested all the functionalities that have been changed.