search

biolab / orange-canvas-core

Orange Canvas core workflow editor
GNU General Public License v3.0
36 stars 62 forks source link

[FIX] Reconfigure stylesheet on application palette change #291

Closed ales-erjavec closed 9 months ago

ales-erjavec commented 10 months ago

Issue

Fixes https://github.com/biolab/orange3/issues/6653

Changes

Reconfigure stylesheet on application palette change

codecov-commenter commented 10 months ago

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (cbf2e9a) 75.57% compared to head (76e5981) 75.63%. Report is 2 commits behind head on master.

Files Patch % Lines
orangecanvas/main.py 90.90% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #291 +/- ## ========================================== + Coverage 75.57% 75.63% +0.06% ========================================== Files 99 99 Lines 21047 21066 +19 ========================================== + Hits 15906 15934 +28 + Misses 5141 5132 -9 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

janezd commented 10 months ago

I could reproduce the bug - labels indeed disappeared. After this PR, switching to dark mode has no effect - that is, labels remain black (and background remains white). Was this the intention?

ales-erjavec commented 10 months ago

No. It is supposed to change:

Screen Recording 2023-12-08 at 11 41 53 mov

What version of PyQt do you have installed? I am testing with PyQt6 6.5

janezd commented 9 months ago

Note from Slack: Python 3.10 from Conda is linked with macOS SDK 10.9 and does not receive palette change events. As suggested by @ales-erjavec, I tried with 3.11 and it works.