biolab / orange3-educational

🍊 πŸŽ“ Educational widgets for machine learning and data mining in Orange 3.
Other
27 stars 20 forks source link

Random Data: Improve parsing of decimal values #116

Closed janezd closed 3 years ago

janezd commented 3 years ago
Issue

Should fix #101.

Description of changes

@bughunter12345, I apologize this took so long. I couldn't (and still can't) reproduce the problem and, more importantly, this add-on was -- although we use it regularly -- somewhat neglected before becoming this year's summer project for me. :)

I added some code that should make parsing decimal numbers more robust. If you have time and you know how to and you're still interested, please check whether this fixes the problem. If not, @ajdapretnar will when she returns from vacation (right? :).

Includes
codecov-commenter commented 3 years ago

Codecov Report

Merging #116 (78d24be) into master (9bf8395) will increase coverage by 0.04%. The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #116      +/-   ##
==========================================
+ Coverage   82.83%   82.87%   +0.04%     
==========================================
  Files          17       17              
  Lines        2977     2984       +7     
  Branches      349      350       +1     
==========================================
+ Hits         2466     2473       +7     
  Misses        458      458              
  Partials       53       53              
Impacted Files Coverage Ξ”
orangecontrib/educational/widgets/owrandomdata.py 97.83% <100.00%> (+0.04%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Ξ” = absolute <relative> (impact), ΓΈ = not affected, ? = missing data Powered by Codecov. Last update 9bf8395...78d24be. Read the comment docs.

ajdapretnar commented 3 years ago

This does fix the issue with the decimals, so I am merging. One issue still remains. Try using 1.e as the variance value. The widget will crash.