search

biolab / orange3-educational

🍊 🎓 Educational widgets for machine learning and data mining in Orange 3.
Other
27 stars 20 forks source link

KMeans: Fix problem with adding centroids #123

Closed janezd closed 3 years ago

janezd commented 3 years ago
Issue

Centroids were sometimes not added on-click.

Description of changes

If the user moved the mouse while clicking on empty space, the plot recorded this as dragging and didn't add a centroid.

While this certainly did happen, I don't know whether that's the only problem or there's something else as well. I can't reproduce the problem any longer, anyway.

Includes
codecov-commenter commented 3 years ago

Codecov Report

Merging #123 (82a657c) into master (eabe56c) will not change coverage. The diff coverage is 0.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #123   +/-   ##
=======================================
  Coverage   82.91%   82.91%           
=======================================
  Files          17       17           
  Lines        3014     3014           
  Branches      352      352           
=======================================
  Hits         2499     2499           
  Misses        461      461           
  Partials       54       54
Impacted Files Coverage Δ
orangecontrib/educational/widgets/owkmeans.py 80.53% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update eabe56c...82a657c. Read the comment docs.