search

biolab / orange3-educational

🍊 🎓 Educational widgets for machine learning and data mining in Orange 3.
Other
27 stars 20 forks source link

[FIX] Polynomial Classification: many bugs #38

Closed jerneju closed 7 years ago

jerneju commented 7 years ago
Issue

Several errors.

Description of changes

1) Disable tests which take too much time (Travis failed due to TimeoutError). 2) Upgrade to Inputs and Outputs and fix tests in all four widgets. 3) Upgrade to class Warning. 4) Upgrade to iteration over domain.variables and not domain. 3) Concatenate lists not tuple and lists in Polynomial Classification. 4) Fitting bug in Polynomial Classification handled.

Includes
jerneju commented 7 years ago

https://sentry.io/biolab/orange3-educational/issues/397068360/

jerneju commented 7 years ago

https://sentry.io/biolab/orange3-educational/issues/323251041/

codecov-io commented 7 years ago

Codecov Report

:exclamation: No coverage uploaded for pull request base (master@85707d7). Click here to learn what that means. The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff            @@
##             master     #38   +/-   ##
========================================
  Coverage          ?   91.4%           
========================================
  Files             ?      15           
  Lines             ?    1769           
  Branches          ?     210           
========================================
  Hits              ?    1617           
  Misses            ?     116           
  Partials          ?      36
Impacted Files Coverage Δ
...gecontrib/educational/widgets/owgradientdescent.py 80.9% <100%> (ø)
orangecontrib/educational/widgets/owkmeans.py 95.54% <100%> (ø)
...trib/educational/widgets/owpolynomialregression.py 96.53% <100%> (ø)
.../educational/widgets/owpolynomialclassification.py 98.26% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 85707d7...7fab94b. Read the comment docs.

kernc commented 7 years ago

lmk when this is ready to review.