biolab / orange3-educational

🍊 πŸŽ“ Educational widgets for machine learning and data mining in Orange 3.
Other
27 stars 20 forks source link

[FIX] Gradient Descent: work on sparse #45

Closed jerneju closed 6 years ago

jerneju commented 6 years ago
Issue

Does not work on sparse.

Description of changes

Convert those two or three columns which are needed to dense.

Includes
jerneju commented 6 years ago

https://sentry.io/biolab/orange3-educational/issues/417311830/

codecov-io commented 6 years ago

Codecov Report

Merging #45 into master will increase coverage by 0.18%. The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #45      +/-   ##
==========================================
+ Coverage   91.24%   91.42%   +0.18%     
==========================================
  Files          14       14              
  Lines        1782     1785       +3     
  Branches      214      215       +1     
==========================================
+ Hits         1626     1632       +6     
+ Misses        120      118       -2     
+ Partials       36       35       -1
Impacted Files Coverage Ξ”
...gecontrib/educational/widgets/owgradientdescent.py 81.79% <100%> (+0.89%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Ξ” = absolute <relative> (impact), ΓΈ = not affected, ? = missing data Powered by Codecov. Last update 6f2f89c...f54d4e1. Read the comment docs.

PrimozGodec commented 6 years ago

Can you just resolve conflicts? @jerneju

PrimozGodec commented 6 years ago

Thank you @jerneju