search

biolab / orange3-educational

🍊 πŸŽ“ Educational widgets for machine learning and data mining in Orange 3.
Other
27 stars 20 forks source link

[FIX] Polynomial Classification: do not draw contours if no data #50

Closed jerneju closed 6 years ago

jerneju commented 6 years ago
Issue

Put Polynomial Classification on canvas. Click checkbox Show contours. The widget crashes.

Description of changes

Do not try to draw contours if there is no data.

Includes
jerneju commented 6 years ago

https://sentry.io/biolab/orange3-educational/issues/425415926/

codecov-io commented 6 years ago

Codecov Report

Merging #50 into master will increase coverage by <.01%. The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #50      +/-   ##
==========================================
+ Coverage   91.27%   91.28%   +<.01%     
==========================================
  Files          14       14              
  Lines        1788     1790       +2     
  Branches      215      216       +1     
==========================================
+ Hits         1632     1634       +2     
  Misses        121      121              
  Partials       35       35
Impacted Files Coverage Ξ”
.../educational/widgets/owpolynomialclassification.py 98.32% <100%> (+0.01%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Ξ” = absolute <relative> (impact), ΓΈ = not affected, ? = missing data Powered by Codecov. Last update cb4ef13...949cc64. Read the comment docs.

PrimozGodec commented 6 years ago

Looks good, thank you @jerneju.