biolab / orange3-educational

🍊 πŸŽ“ Educational widgets for machine learning and data mining in Orange 3.
Other
27 stars 20 forks source link

[FIX] Polynomial Classification: work on sparse #52

Closed jerneju closed 6 years ago

jerneju commented 6 years ago
Issue

Does not work on sparse.

Description of changes

Similar as #45 .

Also fix check for None.

Includes
codecov-io commented 6 years ago

Codecov Report

Merging #52 into master will increase coverage by 3.57%. The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master     #52      +/-   ##
=========================================
+ Coverage   91.13%   94.7%   +3.57%     
=========================================
  Files          14      14              
  Lines        1793    1794       +1     
  Branches      216     216              
=========================================
+ Hits         1634    1699      +65     
+ Misses        124      69      -55     
+ Partials       35      26       -9
Impacted Files Coverage Ξ”
.../educational/widgets/owpolynomialclassification.py 98.32% <100%> (ΓΈ) :arrow_up:
...gecontrib/educational/widgets/owgradientdescent.py 97.02% <0%> (+15.84%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Ξ” = absolute <relative> (impact), ΓΈ = not affected, ? = missing data Powered by Codecov. Last update 9f3b496...fd36b74. Read the comment docs.

jerneju commented 6 years ago

https://sentry.io/biolab/orange3-educational/issues/439995362/

jerneju commented 6 years ago

https://sentry.io/biolab/orange3-educational/issues/440014395/

PrimozGodec commented 6 years ago

Thank you @jerneju. Just noticed today. Works fine.

jerneju commented 6 years ago

πŸ‘