biolab / orange3-imageanalytics

🍊 :rice_scene: Orange3 add-on for dealing with image related tasks

GNU General Public License v3.0

32 stars 42 forks source link

Proxy support for ImageEmbedding #101

Closed PrimozGodec closed 6 years ago

PrimozGodec commented 6 years ago

Issue

Embedding does not work whe proxy present

Description of changes

The update of Hyper allows us to support proxies in embedding widget.

Includes

[X] Code changes
[ ] Tests
[ ] Documentation

PrimozGodec commented 6 years ago

https://github.com/biolab/orange3-imageanalytics/issues/50

codecov-io commented 6 years ago

Codecov Report

Merging #101 into master will decrease coverage by 0.86%. The diff coverage is 33.33%.

@@            Coverage Diff             @@
##           master     #101      +/-   ##
==========================================
- Coverage   65.96%   65.09%   -0.87%     
==========================================
  Files           5        5              
  Lines         520      530      +10     
  Branches       82       85       +3     
==========================================
+ Hits          343      345       +2     
- Misses        151      156       +5     
- Partials       26       29       +3

PrimozGodec commented 6 years ago

@lanzagar can you just take a look at the code since you have been working with proxies before. I have already tested the solution with the lab proxy and it works.