biolab / orange3-imageanalytics

🍊 :rice_scene: Orange3 add-on for dealing with image related tasks
GNU General Public License v3.0
32 stars 42 forks source link

Embedders widget - field for a custom server URL #114

Open PrimozGodec opened 6 years ago

PrimozGodec commented 6 years ago
Issue

No possibility to set custom server url.

Description of changes

Adding a field and functionality for a custom URL set.

Includes
codecov-io commented 6 years ago

Codecov Report

Merging #114 into master will decrease coverage by 3.72%. The diff coverage is 100%.

@@            Coverage Diff             @@
##           master     #114      +/-   ##
==========================================
- Coverage    79.9%   76.18%   -3.73%     
==========================================
  Files           7        5       -2     
  Lines         622      529      -93     
  Branches       95       84      -11     
==========================================
- Hits          497      403      -94     
- Misses         97       98       +1     
  Partials       28       28
matjazp commented 6 years ago

we also need "allow insecure" option, eg. like in curl -k or --insecure (Allow connections to SSL sites without checking certs (H)). We need this if there are self signed certificates installed on the imageanalytics server.

PrimozGodec commented 6 years ago

@lanzagar fixed @matjazp will try to implement. @acopar is it possible to set up a server with the self-generated certificate to test Matjaz's suggestion.

PrimozGodec commented 6 years ago

@matjazp it seems that hyper library does not support "allow insecure" option https://hyper.readthedocs.io/en/latest/advanced.html#ssl-tls-certificate-verification. With @acopar we discussed to just use HTTP instead of HTTPS those cases

Corlobin commented 5 years ago

Very useful!!