biolab / orange3-imageanalytics

🍊 :rice_scene: Orange3 add-on for dealing with image related tasks
GNU General Public License v3.0
32 stars 42 forks source link

Inception default and force to switch to local embedder when no connection to the server #126

Closed PrimozGodec closed 5 years ago

PrimozGodec commented 5 years ago
Issue

Squeezenet default - limited statistcs. When no connection to the server remote embedders will not work.

Description of changes

Set Inception as a default. When no connection switched to local embedder. Switching is made only when new data at the input. When old data present they can be evaluated with the same embedder due to the local cache.

Includes
PrimozGodec commented 5 years ago

@matjazp can you check this?

PrimozGodec commented 5 years ago

@acopar can you check my solution for pinging, let me know if you agree with the solution and test it very accurately?

matjazp commented 5 years ago

beware, it's not the same stuff. We used HTTP/2 PING frame (https://http2.github.io/http2-spec/#PING) with hyper, but you now only send "normal" single ping (single packet as ICMP echo request). In the first case we check if HTTP/2 connection is still open/available at transport layer (so basically it's over TCP), in the second case this is a check at the network (IP) layer.

codecov-io commented 5 years ago

Codecov Report

Merging #126 into master will decrease coverage by 0.06%. The diff coverage is 66.66%.

@@            Coverage Diff            @@
##           master    #126      +/-   ##
=========================================
- Coverage   82.47%   82.4%   -0.07%     
=========================================
  Files           7       7              
  Lines         622     631       +9     
  Branches       95      97       +2     
=========================================
+ Hits          513     520       +7     
+ Misses         83      80       -3     
- Partials       26      31       +5