biolab / orange3-imageanalytics

🍊 :rice_scene: Orange3 add-on for dealing with image related tasks
GNU General Public License v3.0
32 stars 42 forks source link

Image grid lables #136

Closed PrimozGodec closed 5 years ago

PrimozGodec commented 5 years ago
Issue

Implements https://github.com/biolab/orange3-imageanalytics/issues/113

Description of changes

Adding labels at the bottom of images in the grid.

Includes
codecov[bot] commented 5 years ago

Codecov Report

Merging #136 into master will increase coverage by <.01%. The diff coverage is 69.04%.

@@            Coverage Diff             @@
##           master     #136      +/-   ##
==========================================
+ Coverage    60.1%   60.11%   +<.01%     
==========================================
  Files          18       18              
  Lines        3161     3174      +13     
  Branches      439      439              
==========================================
+ Hits         1900     1908       +8     
- Misses       1135     1140       +5     
  Partials      126      126
codecov[bot] commented 5 years ago

Codecov Report

Merging #136 into master will increase coverage by 0.41%. The diff coverage is 84.5%.

@@            Coverage Diff             @@
##           master     #136      +/-   ##
==========================================
+ Coverage    60.1%   60.52%   +0.41%     
==========================================
  Files          18       18              
  Lines        3161     3202      +41     
  Branches      439      444       +5     
==========================================
+ Hits         1900     1938      +38     
- Misses       1135     1139       +4     
+ Partials      126      125       -1
PrimozGodec commented 5 years ago

I also tested it on Windows and it looks ok - same than macOS. @ajdapretnar and @robertcv can you check?

robertcv commented 5 years ago

It crashes when changing input data.

PrimozGodec commented 5 years ago

@robertcv it should be fixed now

PrimozGodec commented 5 years ago

I fixed the tests so it can be merged if everything is OK @robertcv