biolab / orange3-imageanalytics

🍊 :rice_scene: Orange3 add-on for dealing with image related tasks

GNU General Public License v3.0

32 stars 42 forks source link

[FIX] Embedder must work with table #158

Closed PrimozGodec closed 5 years ago

PrimozGodec commented 5 years ago

Issue

Since long ago there was added an origin field in the table ImageEmbedder didn't properly support Table inputs.

Description of changes

Fixed support for Table in ImageEmbedder
Since fix includes the duplication of code from the widget this part of the code is now removed from the widget and widget now passes the table to embedder.
Tests

Includes

[X] Code changes
[X] Tests
[ ] Documentation

codecov[bot] commented 5 years ago

Codecov Report

Merging #158 into master will increase coverage by 0.38%. The diff coverage is 100%.

@@            Coverage Diff             @@
##           master     #158      +/-   ##
==========================================
+ Coverage   60.75%   61.14%   +0.38%     
==========================================
  Files          13       13              
  Lines        3254     3253       -1     
  Branches      483      482       -1     
==========================================
+ Hits         1977     1989      +12     
+ Misses       1149     1140       -9     
+ Partials      128      124       -4