Closed PrimozGodec closed 4 years ago
I've tried it and it looks ok. There's one thing that I'm unsure of. When I select a dropdown, but I don't change the attribute, the computation is always restarted. Seems unnecessary, but perhaps it is how Qt works.
Merging #182 into master will increase coverage by
0.11%
. The diff coverage is88.23%
.
@@ Coverage Diff @@
## master #182 +/- ##
==========================================
+ Coverage 66.36% 66.47% +0.11%
==========================================
Files 13 13
Lines 2997 3001 +4
Branches 439 439
==========================================
+ Hits 1989 1995 +6
+ Misses 890 888 -2
Partials 118 118
I've tried it and it looks ok. There's one thing that I'm unsure of. When I select a dropdown, but I don't change the attribute, the computation is always restarted. Seems unnecessary, but perhaps it is how Qt works.
Yes, it is how Qt works. Anyway, I added a workaround since recomputation in this widget is quite expensive.
Issue
Description of changes
Includes