search

biolab / orange3-imageanalytics

🍊 :rice_scene: Orange3 add-on for dealing with image related tasks
GNU General Public License v3.0
32 stars 42 forks source link

Update requirements for translation (and fix oldest tests) #221

Closed markotoplak closed 1 year ago

markotoplak commented 1 year ago
Issue

Due to some incompatible requirements oldest tests actually install the latest version (so we have bugs).

codecov[bot] commented 1 year ago

Codecov Report

Merging #221 (3553c95) into master (37caba2) will increase coverage by 0.03%. The diff coverage is 100.00%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #221 +/- ## ========================================== + Coverage 68.87% 68.91% +0.03% ========================================== Files 17 17 Lines 2818 2815 -3 Branches 392 392 ========================================== - Hits 1941 1940 -1 + Misses 768 766 -2 Partials 109 109 ```
markotoplak commented 1 year ago

So, whenever we change requirements, we must ensure that the oldest tests install the correct versions.

Before, oldest tests used Orange 3.31, but requirements wanted at least 3.32. Therefore, the preinstalled oldest packages could not satisfy this package's dependencies, so these were updated: the latest released version was installed.

Therefore we did not notice that adding translations required updating requirements.

I remember fixing similar things for orange3-geo, so perhaps we need something automated. @JakaKokosar, could we somehow modify package installation in tox so that preinstalled (oldest) packages were "locked"?