biolab / orange3-imageanalytics

🍊 :rice_scene: Orange3 add-on for dealing with image related tasks
GNU General Public License v3.0
32 stars 42 forks source link

[ENH] Image Viewer - remember selection #230

Closed PrimozGodec closed 1 year ago

PrimozGodec commented 1 year ago
Issue

The image Viewer widget does not remember the selection. It also fails when images are selected, and a smaller set of images is on the input so that the selection index is greater than the length of a new dataset.

Description of changes

Implement selection as the schema-only ContextSetting, which stores image names.

This PR also:

Includes
codecov[bot] commented 1 year ago

Codecov Report

Merging #230 (a1d8798) into master (faeabf7) will increase coverage by 2.90%. The diff coverage is 87.50%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #230 +/- ## ========================================== + Coverage 69.63% 72.53% +2.90% ========================================== Files 18 18 Lines 2832 2844 +12 Branches 393 395 +2 ========================================== + Hits 1972 2063 +91 + Misses 748 666 -82 - Partials 112 115 +3 ```
PrimozGodec commented 1 year ago

@janezd, I changed the selection setting to store image names. It is ready for review.